Keep the collapse state of a tree-view

[alvsan09]

The 'collapse' state of a tree view is preserved, however setting the
hidden state to false was incorrectly cascading to collapse
false.

NOTE: The issue can be reproduced using a tree-view provided by a plugin
which uses a when clause to open it.

Fixes: #9578
Signed-off-by: Alvaro Sanchez-Leon [email protected]

What it does

Removes a condition which incorrectly caused this types of views to expand when the hidden state was set to false

How to test

1. Use the following tree view extension example or the 'npm' scripts view.
   The extension provides a tree-view called JSON OUTLINE which is activated when the open file in editor is a json file i.e. It uses a when clause.
2. Open a 'json' file in editor to make sure the 'JSON OUTLINE' opens.
3. Follow the sequence as shown in the following .gif files to reproduce and then verify the fix.
   

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[msujew]

@alvsan09 Thank you for your contribution.

I can confirm that the issue is present on master and is fixed by your changes:

Closing the npm container and reloading the application will re-open the container on master. Repeating the same with your changes keeps the npm container closed after reloading.

I wasn't able to find any regressions with this approach.

[vince-fugnitto]

I confirmed that the tree-view part collapsed state is preserved on reloads under different conditions:

• confirmed that collapsing all parts are preserved on reload.
• confirmed under different conditions that parts are preserved on reload (collpased + uncollapsed).
• confirmed that the reset workbench layout properly resets the layout, and parts explicitly collapsed by users are reset.