Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add resource property-view unit-tests #9630

Merged

Conversation

OmarSdt-EC
Copy link
Contributor

@OmarSdt-EC OmarSdt-EC commented Jun 22, 2021

What it does

Add unit-tests for:

  • resource-property-data-service.ts
  • resource-property-view-label-provider.ts.

How to test

The CI should be green and the new tests should be executed.
You can also manually run the tests with npx run test @theia/property-view.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added property-view issues related to the property-view extension test issues related to unit and api tests labels Jun 22, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good, just some minor comments 👍

@OmarSdt-EC OmarSdt-EC force-pushed the os/tests_propertyView branch from 9544c6e to c6e31be Compare June 22, 2021 19:05
This commit adds unit-tests for the resource-property-data-service.ts
and resource-property-view-label-provider.ts files.
@OmarSdt-EC OmarSdt-EC force-pushed the os/tests_propertyView branch from c6e31be to 1947ab5 Compare June 22, 2021 19:15
@vince-fugnitto vince-fugnitto merged commit bd12178 into eclipse-theia:master Jun 28, 2021
@vince-fugnitto vince-fugnitto added this to the 1.15.0 milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
property-view issues related to the property-view extension test issues related to unit and api tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants