Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsx-registry: add support for additional queries #9572

Merged
merged 1 commit into from
Jun 14, 2021
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request adds support for additional special queries for the extensions-view.
The special queries are the following:

  • @builtin: displays the builtin tree-view part with all builtin extensions.
  • @installed: displays the installed tree-view part with all installed extensions.

The change also includes the following commands:

  • Extensions: Show Built-in Extensions: triggers the @builtin query.
  • Extensions: Show Installed Extensions: triggers the @installed query.

How to test

  1. start the application, open the extensions-view and install at least one extension
  2. execute the command Extensions: Show Built-in Extensions and ensure the query is satisfied displaying all builtin extensions.
  3. execute the command Extensions: Show Installed Extensions and ensure the query is satisfied displaying all installed extensions.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

The commit adds support for additional queries:
- `@builtin`
- `@installed`

The changes also include commands to open the `extensions-view` with the
corresponding query.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added the vsx-registry Issues related to Open VSX Registry Integration label Jun 9, 2021
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me, and behaves as expected. 👍

@vince-fugnitto vince-fugnitto merged commit 6067172 into master Jun 14, 2021
@vince-fugnitto vince-fugnitto deleted the vf/vsx-query branch June 14, 2021 12:24
@github-actions github-actions bot added this to the 1.15.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants