plugin: support prefix arguments for workbench.action.quickOpen
#9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/quickopen-prefix
branch
from
47aaffa to
13d4654
Compare
The commit adds support for `prefix` arguments when plugins execute the `workbench.action.quickOpen` command. Previously `prefix` arguments were ignored. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/quickopen-prefix
branch
from
13d4654 to
b91228f
Compare
paul-marechal
approved these changes
Jun 8, 2021
|
Thanks, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9565
The commit adds support for
prefixarguments when plugins execute theworkbench.action.quickOpencommand. Previouslyprefixarguments were ignored.How to test
vscode-quickopentest extension to yourpluginsfolder.QuickOpen: Open (No Prefix)- the default behavior should occur with the defaultquickOpen.QuickOpen: Open (Prefix)- thequick-commandinput should be triggered with theprefix.QuickOpen: Open (Invalid Prefix)- the default behavior should occur, an error should be raised.Videos
prefix:
prefix.mov
invalid prefix:
invalid-prefix.mov
no prefix:
no-prefix.mov
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]