Remove 'All Files' filter if OpenFileDialogProps filters are configured #9558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use the default * filter when no filter has been specified in the SaveFileDialogProps props. Signed-off-by: Scott Axcell <[email protected]>
There was a problem hiding this comment.
@scottaxcell thank you for the pull-request, I believe a fix for the filters has already been submitted? #9502 (which also fixes the electron use-case)
|
Thanks @vince-fugnitto, you're correct, sorry I missed the existing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9242
How to test
.vsixfile.extensionsview._more_menu item in the toolbar and execute theInstall from VSIX...command.VSIX Extensions (*.vsix).Review checklist
Reminder for reviewers
Signed-off-by: Scott Axcell [email protected]