SIW: Support 'search.smartCase' #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
enhancement
DucNgn
force-pushed
the
dn/SIW-smartCase
branch
from
2a2c80a to
1907c40
Compare
The following commit adds support for the preference 'search.smartCase'. When the preference is true, search is case-insensitive if the pattern is all lowercase, otherwise search is case-sensitive. Signed-off-by: Duc Nguyen <[email protected]>
DucNgn
force-pushed
the
dn/SIW-smartCase
branch
from
1907c40 to
a922468
Compare
vince-fugnitto
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
I confirm that the pull-request works for the following use-cases:
- search results are case-insensitive by default.
- search results still respect the available options (
match case). - search results are case-intensive when the preference is on, and the query is lowercase.
- search results are case sensitive when the preference is on, and the query contains at least one uppercase character.
- search results are correctly re-applied on startup with the preference on.
|
@alvsan09 would you like to review as well since you're now familiar with |
Sure, I will review it and test it !! |
alvsan09
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following commit adds support for the preference 'search.smartCase'.
When the preference is true, search is case-insensitive if the pattern
is all lowercase, otherwise search is case-sensitive.
How to test
With
search.smartCaseturned on (default is off).hello)Hello,HeLlo, etc are shown up in the result view).Hello).heLlo,helloare now not showing up).Review checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen [email protected]