Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: Add 'Toggle Full Screen' Command #9399

Merged

Conversation

seantan22
Copy link
Contributor

@seantan22 seantan22 commented Apr 23, 2021

What it does

  • Enables full screen toggling of Electron window.

How to test

  • Search for Toggle Full Screen in the command palette and execute.
  • Or, use f11 keybinding on Windows.
  • Or, use ctrl+ctrlcmd+f keybinding on MacOS.

Review checklist

Reminder for reviewers

Signed-off-by: seantan22 [email protected]

@seantan22 seantan22 changed the title Electron: Add Toggle Full Screen Command Electron: Add 'Toggle Full Screen' Command Apr 23, 2021
What it does
- Enables full screen toggling of Electron window.

How to test
- Search for `Toggle Full Screen` in the command palette and execute.
- Or, use `f11` keybinding on Windows.
- Or, use `ctrl+ctrlcmd+f` keybinding on MacOS.

Signed-off-by: seantan22 <[email protected]>
@seantan22 seantan22 force-pushed the st/toggle-full-screen branch from ec7de42 to 899204e Compare April 23, 2021 15:58
@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Apr 26, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the pull-request works as intended 👍

Copy link
Contributor

@DucNgn DucNgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.
I confirmed the command and keybinding work correctly for me (MacOS).

@vince-fugnitto vince-fugnitto merged commit 9e8ae7d into eclipse-theia:master Apr 28, 2021
@vince-fugnitto vince-fugnitto deleted the st/toggle-full-screen branch April 28, 2021 18:24
@vince-fugnitto vince-fugnitto added this to the 1.13.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants