Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format error logs in debug module [issue 9244] #9386

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Format error logs in debug module [issue 9244] #9386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/debug/src/browser/console/debug-console-items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ export class DebugVariable extends ExpressionContainer {
this.elements = undefined;
this.session['fireDidChange']();
} catch (error) {
console.error(error);
console.error('setValue failed:', error);
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/debug-session-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export class DebugSessionManager {
await this.shell.saveAll();
return true;
} catch (error) {
console.error(error);
console.error('saveAll failed:', error);
return false;
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/debug/src/browser/debug-session.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ export class DebugSession implements CompositeTreeElement {
try {
await thread.pause();
} catch (e) {
console.error(e);
console.error('pauseAll failed:', e);
}
})());
}
Expand All @@ -187,7 +187,7 @@ export class DebugSession implements CompositeTreeElement {
try {
await thread.continue();
} catch (e) {
console.error(e);
console.error('continueAll failed:', e);
}
})());
}
Expand Down Expand Up @@ -416,7 +416,7 @@ export class DebugSession implements CompositeTreeElement {
const threads = response && response.body && response.body.threads || [];
this.doUpdateThreads(threads, stoppedDetails);
} catch (e) {
console.error(e);
console.error('updateThreads failed:', e);
}
});
}
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/browser/model/debug-thread.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class DebugThread extends DebugThreadData implements TreeElement {
}
return this.doUpdateFrames(frames);
} catch (e) {
console.error(e);
console.error('fetchFrames failed:', e);
return [];
} finally {
if (!cancel.isCancellationRequested) {
Expand Down
10 changes: 5 additions & 5 deletions packages/debug/src/node/debug-adapter-contribution-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class DebugAdapterContributionRegistry {
const result = await contribution.provideDebugConfigurations(workspaceFolderUri);
configurations.push(...result);
} catch (e) {
console.error(e);
console.error('provideDebugConfigurations failed:', e);
}
}
}
Expand All @@ -108,7 +108,7 @@ export class DebugAdapterContributionRegistry {
return current;
}
} catch (e) {
console.error(e);
console.error('resolveDebugConfiguration failed:', e);
}
}
}
Expand All @@ -133,7 +133,7 @@ export class DebugAdapterContributionRegistry {
return current;
}
} catch (e) {
console.error(e);
console.error('resolveDebugConfigurationWithSubstitutedVariables failed:', e);
}
}
}
Expand All @@ -152,7 +152,7 @@ export class DebugAdapterContributionRegistry {
try {
schemas.push(...await contribution.getSchemaAttributes());
} catch (e) {
console.error(e);
console.error('getSchemaAttributes failed:', e);
}
}
}
Expand All @@ -165,7 +165,7 @@ export class DebugAdapterContributionRegistry {
try {
schemas.push(...await contribution.getConfigurationSnippets());
} catch (e) {
console.error(e);
console.error('getConfigurationSnippets failed:', e);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/debug/src/node/debug-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class DebugServiceImpl implements DebugService {
try {
await this.doStop(session);
} catch (e) {
console.error(e);
console.error('terminateDebugSession failed:', e);
}
})());
}
Expand Down