Activate pinned editor only if already active #9346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-grant-work
added
bug
Signed-off-by: Colin Grant <[email protected]>
colin-grant-work
force-pushed
the
bugfix/preview-activate-on-pinned
branch
from
65cc6d1 to
302f87c
Compare
vince-fugnitto
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
@colin-grant-work thank you, I confirmed that it successfully fixes the use-case 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9268 by preventing a newly pinned editor widget from activating when it was not previously the active widget.
How to test
editor.enablePreviewand ensure that the preference is set to totrue(default).editor.enablePreviewto false.Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant [email protected]