Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSX: Add Extension Context-Menu & Copy Commands #9292

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

seantan22
Copy link
Contributor

What it does

  • Adds a context-menu to each extension to which extension-specific commands can be registered; accessible through the gear icon. (Potential extension-specific commands to add: Install Another Version..., Enable, Disable, Extension Settings.)
  • Adds support for Copy and Copy Extension Id commands.

image

How to test

  • Open the extensions-view.
  • Select an extension and click the gear icon.
  • Click either the Copy command or the Copy Extension Id command.
  • Paste results in a text-editor to confirm that the appropriate information was copied.

Review checklist

Reminder for reviewers

Signed-off-by: seantan22 [email protected]

@vince-fugnitto vince-fugnitto added the vsx-registry Issues related to Open VSX Registry Integration label Apr 1, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the following 👍

  • the context-menu is correctly rendered.
  • the copy extension id command works correctly.
  • the copy command works correctly for installed, builtin and local extensions.

@seantan22 seantan22 force-pushed the st/copy-commands branch 4 times, most recently from f66f98d to 72e9cfa Compare April 7, 2021 16:24
What it does
- Adds a context-menu to each extension to which extension-specific commands can be registered; accessible through the gear icon.
- Adds support for `Copy` and `Copy Extension Id` commands.

How to test
1. Open the _extensions-view_.
2. Select an extension and click the gear icon.
3. Click either the `Copy` command or the `Copy Extension Id` command.
4. Paste results in a text-editor to confirm that the correct information was copied.

Signed-off-by: seantan22 <[email protected]>
@vince-fugnitto vince-fugnitto merged commit b722e4d into eclipse-theia:master Apr 12, 2021
@vince-fugnitto vince-fugnitto added this to the 1.13.0 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vsx-registry Issues related to Open VSX Registry Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants