Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-9262: Fixed the double hover issue for the currentFrame editor #9256

Merged

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 25, 2021

What it does

  • This PR disables the default editor-contribution hover (such has textdocument/hover for JS/TS) from monaco for the currentFrame editor.
  • Fixes the string, number, and boolean coloring in the debug hover and the Variables view.
  • This PR makes the debug hover content hidden when the expression is not complex (!expression.hasChildren).

Closes #9262

How to test

const x = 'alma';
const y = 36;
const z = true;
const complex = {
    foo: 'bar'
};
const large = {
    ...complex,
    'some string': 1
};

console.log(x, y, z, complex, large);
  • Test with the snippet.
  • Before the debug session, verify that you can see the default editor hover.
  • Start a debug session, check that the default hover is not there. (Please also check the color of the variables),
  • Stop the debug session, the default hover is available again.
  • Verify the colors in the Variables view.

Screen Shot 2021-03-29 at 10 54 26

screencast.2021-03-29.10-53-07.mp4

Review checklist

Reminder for reviewers

@kittaakos kittaakos force-pushed the align-debug-popup-with-vscode branch from efbd89c to 132ce03 Compare March 29, 2021 08:48
@kittaakos kittaakos changed the title [WIP]: fixed double hover issue in debug mode GH-9262: Fixed the double hover issue for the currentFrame editor Mar 29, 2021
@kittaakos kittaakos marked this pull request as ready for review March 29, 2021 09:00
@kittaakos kittaakos force-pushed the align-debug-popup-with-vscode branch from 132ce03 to 0655dec Compare March 29, 2021 17:21
@kittaakos kittaakos force-pushed the align-debug-popup-with-vscode branch from 0655dec to 346c01f Compare March 30, 2021 07:35
…itor.

Enabled debug hover coloring for strings, numbers, and booleans.

Closes eclipse-theia#9262

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos force-pushed the align-debug-popup-with-vscode branch from 346c01f to c00deda Compare March 30, 2021 13:15
@kittaakos
Copy link
Contributor Author

@colin-grant-work, @marechal-p, I have made the changes based on your feedback. Could you please continue with the review. Thanks!

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I verified that hovering is only showing either debug or LS info depending on the debugging state, and that colors are better.

@kittaakos
Copy link
Contributor Author

Thank you!

@kittaakos kittaakos merged commit 22dcd7e into eclipse-theia:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[debug] Multiple hovers are available when inspecting a variable in the editor with the currentFrame
3 participants