VSX: Add 'Local' PluginType

[seantan22]

What it does

• With VSX: Add Toolbar Menu and Support 'Install from VSIX...' Command #9184, there is a need to differentiate between user-installed extensions that originate from the vsx-registry and those that are uploaded from a local .vsix file.
• Adds Local as a PluginType to refer to plugins that are installed locally (e.g. uploaded using Install From VSIX...)

How to test

1. Open the extensions-view.
2. Install an extension using the Install From VSIX... command.
3. Confirm that the extension is of PluginType Local.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: seantan22 [email protected]

[DucNgn]

LGTM 👍

[vince-fugnitto]

@benoitf any objections to introducing the local plugin-type which helps differentiate between system installed, user installed and local (uploaded) extensions?

[benoitf]

hello, to me it looks like it's still a User scope as it's installed by the user (not a built-in)

it seems we're making a specific case around openvsx registry.

[paul-marechal]

In this case what's the actual meaning for plugin type? If it is solely to differentiate between builtins and non-builtins, should we make a new field pluginOrigin to denote if the plugin came from openvsx or --plugins dir? Do we need to differentiate those plugins in the first place?

[benoitf]

@marechal-p yes I think you're more interested in adding the original source
For example let say you could tomorrow use VS Code marketplace (or you use another marketplace, local should not be tied to 'open-vsix' but openvsx extension is interested in getting all plugins having that flag (and be with user or system scope)

For example you might still be interested to know that a 'default extension' has still updates, etc. (so it's a System plugin type but you may want to check something around it)

[vince-fugnitto]

Closing in favor of an upcoming pull-request which handles local plugins directly in @theia/vsx-registry.