7738-view-data-not-populated

[danarad05]

switching between view containers could cause view not to be populated with data

Signed-off-by: Dan Arad [email protected]

What it does

Fixes: #7738

How to test

1. Load Theia when on Explorer tab and when "NPM scripts" section is expanded
   
2. before NPM scripts are populated with data, switch to "Search" tab and let it finish loading
3. Return to "Explorer" tab - "NPM scripts" should populate shortly.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[danarad05]

FYI @amiramw @offer8

[offer8]

hi @vince-fugnitto can we merge this one before the next release?
It solves us very high bug in multiple stakeholder scenarios.
We verified that the fix solved the issue.

[vince-fugnitto]

hi @vince-fugnitto can we merge this one before the next release?

@offer8 I'll do my best to review but the pull-request is currently not approved. I confirmed it fixes the specific issue but I want to confirm that it is the proper solution. At the moment I see that the event is fired at all times, even if views are collapsed.

[vince-fugnitto]

I confirmed that the pull-request fixes the issue, and that the original logic for expanded state looks correct 👍

[offer8]

thanks @vince-fugnitto can it be part of 1.12.0 https://github.com/eclipse-theia/theia/milestone/17?

[offer8]

thanks @marechal-p !