Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register 'workbench.action.files.openFileFolder' VS Code command #9213

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Mar 17, 2021

What it does

Add support for workbench.action.files.openFileFolder built-in command: #8750

The command should be available for running for:

  • the browser version since Theia dialog supports the feature
  • the Electron version if the system is OSX

How to test

My test extension can be used for testing:

  1. Clone https://github.com/RomanNikitenko/vscode-test-extension.git
  2. Build the extension using yarn and copy it to theia/plugins folder.
  3. Start Theia and open a workspace folder.
  4. F1 => run Test 'workbench.action.files.openFileFolder'

a dialog should be displayed which allows to open a file or a directory

Review checklist

Reminder for reviewers

Signed-off-by: Roman Nikitenko [email protected]

@RomanNikitenko RomanNikitenko force-pushed the openFileFolderCommand branch from 51caf1e to f1b938a Compare March 17, 2021 17:16
@RomanNikitenko
Copy link
Contributor Author

@vzhukovs
Could you test the changes on Mac system as I use another OS.

@RomanNikitenko RomanNikitenko force-pushed the openFileFolderCommand branch from f1b938a to b01fa23 Compare March 17, 2021 21:25
@vzhukovs
Copy link
Contributor

vzhukovs commented Mar 17, 2021

@vzhukovs
Could you test the changes on Mac system as I use another OS.

@RomanNikitenko, checked test extension on Browser Example, Electron Example and VS Code.
Got the following behavior:

  • Theia Browser Example:
openFileFolder-theia.mp4
  • Theia Electron:
openFileFolder-electron.mp4
  • VS Code:
openFileFolder-vscode.mp4

Let me know if there should be an additional use cases that need to be checked.

@RomanNikitenko RomanNikitenko marked this pull request as ready for review March 18, 2021 06:48
@vince-fugnitto vince-fugnitto added dialogs issues related to dialogs vscode issues related to VSCode compatibility labels Mar 18, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, the open dialog that supports files and folders should only be available in the browser, and macos on electron 👍

@RomanNikitenko
Copy link
Contributor Author

Thank you everyone for the review and testing!

@RomanNikitenko RomanNikitenko merged commit 481638e into master Mar 19, 2021
@RomanNikitenko RomanNikitenko deleted the openFileFolderCommand branch March 19, 2021 08:39
@github-actions github-actions bot added this to the 1.12.0 milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialogs issues related to dialogs vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants