Added pmarker sorting by owner

[JonasHelming]

fixed #6572

Signed-off-by: Jonas Helming [email protected]

What it does

adds sorting by owner to problem markers (after severity, line and column

How to test

• Download test workspace from here:
• https://github.com/eclipse-theia/theia/files/5859357/problems-view.zip
• Turn on eslint to get two errors in the first line first column of a.ts
• open a.ts
• open problems view
• open settings and change any setting

See also here: #6572 (comment)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

@JonasHelming thank you for taking the time to improve the sorting. I only have minor comments about formatting and cleanup. Do you also mind updating the commit, we never referred to problem markers as pmarker and it may be confusing to others.

Suggestion:

problems: add fallback marker sort based on 'owner'

Fixes: #6572

The following commit adds an additional problem marker sort based on 'owner` as a fallback to 'severity', 'line number' and 'column number'.

[JonasHelming]

@vince-fugnitto : Thank you for the review, I took all suggestions!

[vince-fugnitto]

I have minor comments, I was unable to produce the secondary owner marker with the example project you provided, what did you do to turn on 'Parsing error has been set for....' in your .gif?

[JonasHelming]

@JonasHelming thank you for taking the time to improve the sorting. I only have minor comments about formatting and cleanup. Do you also mind updating the commit, we never referred to problem markers as pmarker and it may be confusing to others.

Suggestion:

problems: add fallback marker sort based on 'owner'

Fixes: #6572

The following commit adds an additional problem marker sort based on 'owner` as a fallback to 'severity', 'line number' and 'column number'.

done

[JonasHelming]

I have minor comments, I was unable to produce the secondary owner marker with the example project you provided, what did you do to turn on 'Parsing error has been set for....' in your .gif?

I started a Gitpod workspace with the Eclipse Theia code base and launched the example product from there which accesses the example problems workspace.

[JonasHelming]

All comments should be addressed, thanks for the review!

[vince-fugnitto]

Thank you 👍