Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire onDidChangeActiveEmitter when quick-pick is accepted #9175

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Mar 10, 2021

What it does

Set selected quick-pick item as active when a quick-pick item is chosen. This fixes a bug when the active items list is not actual on quick-pick accept event.

fixes eclipse-che/che#19030

How to test

  1. Compile and start the sample plugin or download the sample plugin binary to the plugins folder.
  2. Run F1 => Test Quick-pick and chose Second or Third item.
  3. See: chosen item is printed in a notification.

In the current master theia only First item is returned.

Review checklist

Reminder for reviewers

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig

I can not reproduce the issue for the master branch using your test-plugin - it works well for me without any changes.

@RomanNikitenko
Copy link
Contributor

I see that here you use quickPick.selectedItems[0]. Should it be activeItems instead?

@vinokurig
Copy link
Contributor Author

Yes, you are right, I am sorry I forgot to update the sample plugin. Now the plugin has been updated.

@vinokurig vinokurig added the quick-open issues related to the quick-open label Mar 10, 2021
Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using provided test-plugin - it works well for me!

@vinokurig vinokurig merged commit bb17f71 into master Mar 10, 2021
@vinokurig
Copy link
Contributor Author

@RomanNikitenko thank you for the review!

@github-actions github-actions bot added this to the 1.12.0 milestone Mar 10, 2021
@RomanNikitenko
Copy link
Contributor

@vinokurig
please remove the branch if it's not used anymore

thanks!

@vinokurig vinokurig deleted the fixQuickPick branch March 17, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick-open issues related to the quick-open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not checkout to another branch via the status bar action
2 participants