terminal: fix 'xterm' and addon dependencies to support searching #9167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
|
Turns out the error comes from the addons being incompatible with the latest's xterm version. Solution is to use a different range for xterm as well as updating the addons accordingly. |
vince-fugnitto
force-pushed
the
vf/xterm-fix
branch
from
00a206f to
4b092f2
Compare
|
I've updated the pull-request to bump the version of |
The following commit updates the `xterm` addon dependencies so that they are compatible with the `xterm` version. The changes including pinning the xterm version as to not result in future incompatibilities and updating the addon versions to match. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/xterm-fix
branch
from
4b092f2 to
2514a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #9164
The following commit updates the
xtermaddon dependencies so that they are compatible with thextermversion.The changes including pinning the xterm version as to not result in future incompatibilities and updating the addon
versions to match.
xterm.mov
How to test
ls -al)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]