Fixed the fallback font-family in monaco editor.
#9147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akos Kitta <[email protected]>
vince-fugnitto
added
monaco
vince-fugnitto
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akos Kitta [email protected]
What it does
It fixes the fallback
font-familyin the monaco editor. Instead of falling back to the default UI font, which istheia/packages/core/src/browser/style/variables-dark.useable.css
Line 40 in 1f0689e
we fall back to the desired code editor font, which is
theia/packages/core/src/browser/style/variables-dark.useable.css
Line 52 in 1f0689e
How to test
view-lineselement,font-family.Review checklist
Reminder for reviewers