replace throw with warning when storage is set without workspace #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
any idea why the build is not starting for this PR? |
@amiramw you can try performing an amend and force push to re-trigger the build. |
The functionality is not expected to work according to API, however it doesn't fail in VS Code Signed-off-by: Amiram Wingarten <[email protected]>
vince-fugnitto
added
quality
vince-fugnitto
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality is not expected to work according to API, however it doesn't fail in VS Code
Signed-off-by: Amiram Wingarten [email protected]
What it does
Fixed #8963
How to test
Review checklist
Reminder for reviewers