-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement workspace.workspaceFile extension API #9132
Conversation
53c2127
to
8763593
Compare
This first implementation returns the Uri location of the workspace file even if it is untitled (i.e. saved on a temporary default location). Issue: eclipse-theia#8994 Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
8763593
to
ad42770
Compare
The recent commit adds a new event (onWorkspaceLocationChanged) in order to get notifications for the action "Save as" applied to a work space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified the changes and they work well 👍
I verified the following conditions:
Use-Case | Result |
---|---|
No Workspace | The API correctly returns undefined |
Non Multi-Root Workspace | The API correctly returns undefined |
Unsaved Multi-Root Workspace | The API correctly returns the URI of the temporary workspace file location (untitled) |
Saved Multi-Root Workspace | The API correctly returns the URI of the saved workspace file location |
Hi @kittaakos, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch, @alvsan09 👍
This first implementation returns the Uri location of the workspace
file even if it is untitled (i.e. saved on a temporary default
location).
Fixes: #8994
Signed-off-by: Alvaro Sanchez-Leon [email protected]
What it does
Introduces support for the plugin API: 'vscode.workspace.workspaceFile'
How to test
An test plugin that calls this API is available from: plugin
Once installed issue the command: "Test: Echo Workspace"
Review checklist
Reminder for reviewers