Fixed custom debug request handling. #9131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward the
body
instead of theresponse
object.Signed-off-by: Akos Kitta [email protected]
What it does
Fixes the custom debug message handling. Instead of forwarding the
response
object, it forwards thebody
of asuccess
response.How to test
Try with the Cortex-Debug VS Code extension, you should see reasonable responses, instead of an error:
Error:
Related code in VS Code extension:
https://github.com/Marus/cortex-debug/blob/35f42186726063bcb150f2e4132556a7528eea60/src/frontend/views/registers.ts#L27-L30
With the fix, you can see the custom view contribution with the content from the
cortex-debug
VSX:Review checklist
Reminder for reviewers