Preferences: Support window.zoomLevel Preference #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
electron
DucNgn
approved these changes
Feb 26, 2021
westbury
reviewed
Mar 2, 2021
There was a problem hiding this comment.
Overall looks good. It will be good to have this feature. I did notice that the application always starts at default zoom and then switches to the required zoom. I suspect this is an Electron issue that there is nothing we can do anything about, as Electron does save the zoom amount itself.
packages/core/src/electron-browser/window/electron-window-preferences.ts
Outdated
Show resolved
Hide resolved
packages/core/src/electron-browser/menu/electron-menu-contribution.ts
Outdated
Show resolved
Hide resolved
seantan22
force-pushed
the
st/zoom-level
branch
3 times, most recently
from
266123f to
fb88b6e
Compare
Fixes eclipse-theia#8751 What it does - Allows end-user to specify window zoom level as a preference - Adds support for the addition of other window preferences How to test 1. Open `Preferences` view and locate the `window.zoomLevel` preference 2. Enter in a custom value or change the zoom level using zoom commands (`ctrl +, ctrl -, ctrl 0`) 3. Observe that the window zoom level changes and the preference is updated in the `settings.json` file 4. Reload the window and observe that the preferred zoom level is restored Signed-off-by: seantan22 <[email protected]>
westbury
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8751
How to test
preferences-uiand search for thewindow.zoomLevelpreference.ctrl +,ctrl -,ctrl 0).settings.jsonfile.Review checklist
Reminder for reviewers
Signed-off-by: seantan22 [email protected]