preferences: fix 'number' input validation #9089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
packages/preferences/src/browser/views/components/preference-number-input.tsx
Outdated
Show resolved
Hide resolved
vince-fugnitto
force-pushed
the
vf/numeric-validator
branch
2 times, most recently
from
7f85aef to
4adc1a3
Compare
The following commit fixes the validation for `number` type inputs in the preferences-ui which resulted in false negatives when users attempted to input `0` as a valid value. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/numeric-validator
branch
from
4adc1a3 to
1bf5fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following pull-request fixes the validation logic for numeric preference inputs part of the preferences-view.
Previously, the logic would return false negatives for users attempting to input
0as a valid preference value. The logic was updated to properly validate numeric input fields, and accept0when it is possible.Master:
master-pref.mov
Pull-Request:
pr-pref.mov
How to test
editor.fastScollSensitivity(the preference was used since it should accept0as a value)0- it should be accepted without an error message and remain in the input afteronBluror focus is lostReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]