Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Uplift Python to 3.x #9085

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

DucNgn
Copy link
Contributor

@DucNgn DucNgn commented Feb 18, 2021

What it does

How to test

  • The CI should pass (The ubuntu build might fail because of a known issue with the test suite)

Review checklist

Reminder for reviewers

Signed-off-by: Duc Nguyen [email protected]

+ Drop support for python 2, switch to python 3.

Signed-off-by: Duc Nguyen <[email protected]>
@vince-fugnitto vince-fugnitto added the ci issues related to CI / tests label Feb 18, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and work 👍
It's good we drop support for the Python2 specific builds as it takes time, and Python2 is now EOL.

.github/workflows/build.yml Show resolved Hide resolved
@vince-fugnitto
Copy link
Member

I'll merge the pull-request early next week if there are no objections 👍

@paul-marechal paul-marechal merged commit c5f3253 into eclipse-theia:master Feb 23, 2021
@paul-marechal paul-marechal added this to the 1.11.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues related to CI / tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: drop the 'python 2' builds from Travis
3 participants