9012-registerTerminalLinkProvider-stub: for vscode-java-debug

[danarad05]

Signed-off-by: Dan Arad [email protected]

Added registerTerminalLinkProvider stub which is invoked upon extension activation.

What it does

Fixes first problem of #9012:
vscode-java-debug invokes vscode.window.registerTerminalLinkProvider upon extension activation. This method was not implemented in Theia - added stubs.
For second problem see #9049

How to test

1. Open in Theia java project
2. After load you can run or debug project
   

Approved CQ (existing already) covering theia.d.ts copied code: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677

Note:
for better behavior change this user setting to "internalConsole" (instead of "integratedTerminal"):
"java.debug.settings.console": "internalConsole"

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[colin-grant-work]

Since this PR contains code copied from VSCode, it may require a CQ, so you may want to get that process started.

[amiramw]

Since this PR contains code copied from VSCode, it may require a CQ, so you may want to get that process started.

I checked and this copied code was requested in approved CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677

[colin-grant-work]

I checked and this copied code was requested in approved CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677

Great! So you read that CQ as permitting copying from VSCode 1.51.0 quite broadly, then? If so, that's very nice, and we should update our wiki entry about copying code from VSCode accordingly.

[danarad05]

I checked and this copied code was requested in approved CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677

Great! So you read that CQ as permitting copying from VSCode 1.51.0 quite broadly, then? If so, that's very nice, and we should update our wiki entry about copying code from VSCode accordingly.

@colin-grant-work
Do I understand that you think we should create a new CQ for this PR and not used that one?

[amiramw]

Based on comment by @marcdumais-work in another thread I assume that old CQ that contain the copied code is enough:
#8678 (comment)

[marcdumais-work]

To be clear, it's not enough that there exist a CQ for the same vscode version, the CQ attachment has to contain the copied code, verbatim - i.e. all files we copied-from have to be present (we can then modify our version of what we copied, of course).

If we have several CQs per vscode release, we could discuss if it makes sense for the Foundation to analyse vscode versions as they come-out, wholly and preemptively. Then we would not need a CQ if we copy from a pre-approved version.

I assume that old CQ that contain the copied code is enough:
#8678 (comment)

👍

[vince-fugnitto]

The stub seems fine and it was copied from code covered in the previous CQ:

• https://dev.eclipse.org/ipzilla/show_bug.cgi?id=22677