Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Built-in Extensions Version #9017

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

seantan22
Copy link
Contributor

@seantan22 seantan22 commented Feb 1, 2021

What it does

Fixes #9014

  • Update necessary built-ins to version 1.45.1

How to test

  1. git clone https://github.com/eclipse-theia/theia
  2. cd theia
  3. yarn
    Confirm that all built-ins are successfully downloaded.

Signed-off-by: seantan22 [email protected]

@vince-fugnitto vince-fugnitto added builtins Issues related to VS Code builtin extensions open-vsx issues related to the open-vsx registry labels Feb 1, 2021
What it does

Fixes [eclipse-theia#9014]

- Update necessary built-ins to version 1.45.1

How to test

1. `git clone https://github.com/eclipse-theia/theia`
2. `cd theia`
3. `yarn`
Confirm that all built-ins are successfully downloaded.

Signed-off-by: seantan22 <[email protected]>
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me quickly try it on Gitpod before approving.

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed MarkDown rendering works. Thanks @seantan22!

@marcdumais-work
Copy link
Contributor

CI is green - merging.

@marcdumais-work marcdumais-work merged commit 3b5ebfd into eclipse-theia:master Feb 1, 2021
@vince-fugnitto vince-fugnitto deleted the st/builtin-version branch February 1, 2021 23:58
@vince-fugnitto
Copy link
Member

vince-fugnitto commented Feb 2, 2021

The markdown-language-features extension displays the following error related to custom-editor-apis:

Screen Shot 2021-02-02 at 9 20 17 AM

To reproduce, we can:

  1. open a workspace (ex: theia)
  2. open a markdown file (which is one of the activation events), and the error is displayed

@paul-marechal paul-marechal added this to the 1.11.0 milestone Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins Issues related to VS Code builtin extensions open-vsx issues related to the open-vsx registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails when downloading built-ins
4 participants