Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate the corresponding terminal at using 'Show running tasks' action #9016

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Activate the corresponding terminal at using 'Show running tasks' action #9016

merged 1 commit into from
Feb 3, 2021

Conversation

RomanNikitenko
Copy link
Contributor

@RomanNikitenko RomanNikitenko commented Feb 1, 2021 •
edited
Loading

Signed-off-by: Roman Nikitenko [email protected]

What it does

Fixes #9015

How to test

Please see the Steps to reproduce section of the issue #9015

Review checklist

Reminder for reviewers

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Feb 1, 2021 •
edited
Loading

I confirm the bad behavior on master and the good behavior with this change. Code LGTM. We'll have to rerun CI when the issue with downloading plugins is fixed.

@RomanNikitenko RomanNikitenko marked this pull request as ready for review February 2, 2021 07:48
@RomanNikitenko
Copy link
Contributor Author

@colin-grant-work
thank you for the review!

@RomanNikitenko RomanNikitenko merged commit c9db975 into master Feb 3, 2021
@RomanNikitenko RomanNikitenko deleted the fixShowRunningTask branch February 3, 2021 09:46
@github-actions github-actions bot added this to the 1.11.0 milestone Feb 3, 2021
@magnologan magnologan mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

'Show running tasks' action doesn't activate the corresponding terminal
2 participants
@RomanNikitenko @colin-grant-work