-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for secondary button text not visible in light theme #9008
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@balajiv113 thank you for providing a fix for the styling, do you mind reverting the unnecessary changes (formatting) since it adds noise to the pull-request and makes it more difficult to review. Else, you can group the formatting changes in a secondary commit 👍
@vince-fugnitto Grouped the changes into 2 separate commits as mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the scenario from the issue and Pull Requests comments. Works as expected. Thank you @balajiv113
@balajiv113 do you mind rebasing the pull-request on the latest |
Signed-off-by: Balaji V <[email protected]>
Signed-off-by: Balaji V <[email protected]>
@vince-fugnitto Re-based with current master 👍 |
Thank you for your contribution, and being responsive :) |
Signed-off-by: Balaji V [email protected]
What it does
Fixes #9006
How to test
Follow the steps given in the issue
Review checklist