Fix incomplete data in generated tasks.json #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
6 times, most recently
from
adda4d5 to
084be22
Compare
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
from
084be22 to
d32c003
Compare
vince-fugnitto
requested review from
tsmaeder,
RomanNikitenko and
colin-grant-work
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
from
d32c003 to
b2ac4b4
Compare
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
2 times, most recently
from
6e2f6f4 to
0463885
Compare
|
I've confirmed the bad behavior described in the bug reports on |
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
from
0463885 to
3f178f6
Compare
* Added missing 'group' property to the TaskDto interface * Added group when converting between TaskDto and TaskConfiguration * Added group when converting between TaskDto and Task * Removes clearing of problem matchers (error) to pass the received ones from a given extension. * Align TaskCustomization.group with task schema (i.e. remove 'none' when 'isDefault'). * Include task 'label' in the generated task.json Issues: eclipse-theia#8950 eclipse-theia#8980 Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09
force-pushed
the
fixTerminalConfigTasks
branch
from
3f178f6 to
bf3b07b
Compare
colin-grant-work
approved these changes
Feb 3, 2021
|
Merging :) Thank you for your contribution @alvsan09 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8950
Fixes #8980
How to test
The steps to reproduce the issue are indicated in issues:
the same steps can be used to notice the difference after applying the fix.
The following unit test were updated and pass locally:
npx run test @theia/plugin-extnpx run test @theia/taskReview checklist
Reminder for reviewers
Signed-off-by: Alvaro Sanchez-Leon [email protected]