#8966: Update ViewContainer Toolbars

[colin-grant-work]

Signed-off-by: Colin Grant [email protected]

What it does

Fixes #8966 by adding code to update a ViewContainer part toolbar when a change event is emitted by the TabbarToolbarRegistry.

How to test

Toolbar Part

1. Register a toolbar item that includes a didChange event and should appear in a ViewContainer part (for example, one that is attached to part of the debug panel or one that is attached to the file explorer when a plugin contribution (e.g. NPM) is also present).
2. Hover to reveal the toolbar and fire the command to trigger the didChange event.
3. Observe that the event does affect the ViewContainer part toolbar.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

Approving only based on the code which LGTM.

[paul-marechal]

@colin-grant-work is it possible to contribute such a toolbar item in the sample-apis?

[colin-grant-work]

Yes, definitely. I can do that to make testing easier 👍

[colin-grant-work]

@marechal-p, I've finally gotten around to adding the demo for this to the sample API. I've put a new widget in the explorer area, and if you test with that commit on master, you'll see that the icons don't change until you move your cursor off of the widget, but with the new code from this branch, the icon changes when you click it or when you trigger the action via the button in the widget.

One question adding that widget raises is whether there's a way to use the plugin contributions points within Theia? It seems like there isn't an easy way to say that a view should be added to e.g. the Explorer view container unless it's a plugin.

[vince-fugnitto]

The changes look good to me, I only have some very minor comments regarding formatting 👍

I confirmed (using the provided sample), that the toolbar item is visible when hovering the part, and that clicking either the toolbar item or the button will update the icon correctly. I also confirmed that on master (rolling back view-container.ts) the hovering does work for the same use-case, but clicking the toolbar item or the button will not update the toolbar.

[vince-fugnitto]

minor: add @theia/navigator in alphabetical order, when we perform a release lerna will change the order anyways.

[vince-fugnitto]

minor: add the import with previous imports, we generally add the css import on it's own.

[vince-fugnitto]

minor: syntax for consistency when registering commands (will auto-format correctly after save):

Suggested change

	registry.registerCommand(CHANGE_TO_PLUS_COMMAND,
	{
	registry.registerCommand(CHANGE_TO_PLUS_COMMAND, {

[colin-grant-work]

Closing in favor of #9935, which improves the behavior further.