fix tree view - reveal not to invalidate item command

[amiramw]

Signed-off-by: Amiram Wingarten [email protected]

What it does

The issue is a regression introduced in #8783
Calculation of parent chain (for id calculation) calls getChildren which dispose nodes.
This means that reveal for a node that is already revealed dispose the node and so the frontend has an id that doesn't exist in the backend anymore so tree item command is not found.

The fix is to check the cache before calling getChildren and making sure that the technical root is also in the cache.

How to test

1. Install vsix from https://marketplace.visualstudio.com/items?itemName=SAPSE.sap-ux-application-modeler-extension
2. Copy to workspace the attached project: project1.zip
3. cd project1 && npm i
4. Open Explorer view -> Application Modeler section and select on of the pages. It should open in code editor.
5. Select the other page and it also opens in code editor in separate tab. Without this PR it doesn't open and there is an exception in browser console about command NOT FOUND.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[amiramw]

@kittaakos can you please review this fix?

[kittaakos]

I have verified the steps, it worked. 👍 Thank you!