Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change few terminal logs from error to warning #8908

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

DoroNahari
Copy link
Contributor

Signed-off-by: Doron Nahari [email protected]

What it does

Change few "terminal gone" related logs from error to warning, because when terminal is gone, Theia starts a new terminal instead.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added the terminal issues related to the terminal label Jan 4, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me, I don't have any objections to reducing the severity of the logs.

@amiramw amiramw merged commit 5db308f into eclipse-theia:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants