Fix horizontal scrollbar not to disappear

[kena0ki]

Signed-off-by: Ken Aoki [email protected]

What it does

Fixes #8886.

The module perfect-scrollbar unnecessarily moves the horizontal scrollbar to right. This PR set position attribute for the horizontal scrollbar to static so that it can't be moved.

This PR adds position: relative to style for the scrollbar container as per perfect-scrollbar README.

How to test

1. Open as many files as the scrollbar appears.
2. Scroll to right.
3. Scrollbar should not disappear (not overflow right).

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[kena0ki]

I found position: static also makes bottom unavailable, so another solution is needed.

[kena0ki]

I changed the way to fix.

[DucNgn]

LGTM 👍

I confirm that:

• with many opening files on the tab bar, the scrollbar doesn't disappear when either scroll to right or to left.
• resize the application window, the scrollbar still works as expected.
• resize editor view (horizontally and vertically), the scrollbar still appears when scrolling to both ends.

OS: macOS

[colin-grant-work]

This looks good to me. This feature of perfect scrollbar causes a lot of pain - it's easy to forget to set the position!

[kena0ki]

@dukengn @colin-grant-work Thank you for the review.

Is there anything I need to do for this PR to be merged?
I believe CI failure is not related with this PR.

[colin-grant-work]

@kena0ki, good to go, and now done.

[kena0ki]

@colin-grant-work Thank you!