fix: remove bash login shell when run from task to align with vscode #8834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion: #8818
bash login shell (-l) causing different behavior compared to non login.
for example - it rebuilds the PATH environment and ignore what was defined in theia docker.
this change aligns with vscode that doesn't run with login shell.
Signed-off-by: Amiram Wingarten [email protected]
How to test
After this fix the run is successful. Before this fix it fail with error code 127 as the executable is not found.
Review checklist
Reminder for reviewers