plugin-ext: cleanup

[paul-marechal]

What it does

While working on a different PR I noticed outdated things and went on to fix those.

See commit messages for more information.

How to test

Everything should work like before.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

@benoitf I was a bit confused as to what the /plugin/:path(*) endpoint is used for, do you know if it is used and if so by what?

[benoitf]

@marechal-p do you have tried theia frontend plug-ins as well ?

[paul-marechal]

@benoitf I tried hello world and it worked.

[paul-marechal]

cc @tsmaeder is the /plugin/... endpoint really a left over? Couldn't find where it is used in Theia's sources.

[azatsarynnyy]

What I see from the git history, it has been introduced with the initial implementation of Plug-in system
64903a3#diff-0387516bdf4e48bc4fd1ed19d1db0ef827fd98bbff503e7416b0237d952a4892

I suppose it was replaced later with/hostedPlugin endpoint

theia/packages/plugin-ext/src/hosted/node/plugin-reader.ts

Line 45 in 4641a29

app.get('/hostedPlugin/:pluginId/:path(*)', async (req, res) => {

but the previous one (/plugin) wasn't removed.

Maybe I'm wrong...

[paul-marechal]

@azatsarynnyy I came to the same conclusion too, thanks!

[azatsarynnyy]

I think it's safe to get rid of /plugin/:path(*) endpoint.

[benoitf]

I think it's OK as well to get rid of it, seems to be a leftover

I test it with a couple of plug-ins which is working fine

[paul-marechal]

I fixed the conflicts, thanks!