Paste file/folder to other folder that already contain file/folder with the same name #8778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Does the change fix #4794?
If so, we can link it so it will be closed on merge.
There was a problem hiding this comment.
Does the change fix #4794?
If so, we can link it so it will be closed on merge.
vince-fugnitto
added
CQ Required (deprecated)
|
Hi @vince-fugnitto, |
|
Hi, |
amiramw
approved these changes
Dec 1, 2020
amiramw
removed
the
CQ Required (deprecated)
There was a problem hiding this comment.
@i501378 can you please rebase the pull-request against master so CI (github actions) can run?
…th the same name Signed-off-by: Lital Avigad <[email protected]>
|
@vince-fugnitto Done |
vince-fugnitto
approved these changes
Dec 2, 2020
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lital Avigad [email protected]
What it does
When we want paste file/folder with to other folder that already contain file/folder with the same name, it change the copied file/folder name when we paste it and add to the end of the name
_copy_${index}.This code similar to vscode behavior on this scenario.
How to test
Create folder a with
file.txt.Create folder b with
file.txt.Copy the
file.txtfrom folder b and paste it in folder a.The new file will be added to folder a with name
file_copy.txt.Copy again the
file.txtfrom folder b and paste it in folder a.The new file will be added to folder a with name
file_copy_2.txt.Review checklist
Reminder for reviewers