Update eslint to the latest version #8770
Conversation
Need to rename no-shadow to @typescript-eslint/no-shadow as specified there: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md Change-Id: Ib864501e48772b224b4999718f4f8dfbeb8964d6 Signed-off-by: Florent Benoit <[email protected]>
benoitf
force-pushed
the
fb/update-eslint
branch
from
93706a3 to
ab55839
Compare
vince-fugnitto
added
dependencies
There was a problem hiding this comment.
I verified the following 👍
- I confirmed that the new dependencies are license compatible following the guidelines.
- I confirmed that the new rule works correctly, and pre-existing rules also work with the new eslint update.
|
@vince-fugnitto should I wait somehow to have travis-ci back ? |
@benoitf I build the pull-request locally, and ran the tests (at least on Linux). |
|
so we've successful builds on linux (your case) and macos (my case) so I would say we're fine to merge. |
I believe so, I can have a colleague test on windows if you'd like? |
|
@vince-fugnitto that would be perfect |
@dukengn do you mind confirming the changes work correctly on |
What it does
Update eslint to the latest version
Need to rename no-shadow to @typescript-eslint/no-shadow as specified there
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
How to test
build should be working as I changed only comments in source code
Review checklist
Reminder for reviewers
Change-Id: Ib864501e48772b224b4999718f4f8dfbeb8964d6
Signed-off-by: Florent Benoit [email protected]