preferences: Support 'Close On File Delete' preference #8731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DucNgn
force-pushed
the
dn/stopWidgetsClose
branch
4 times, most recently
from
1ae042b to
7939174
Compare
DucNgn
force-pushed
the
dn/stopWidgetsClose
branch
from
7939174 to
e768066
Compare
+ Add new preference `workbench.editor.closeOnFileDelete` to control whether the editor should be closed if another process deleted or renamed the file. + Change deletedSuffix to ` (deleted)`. Signed-off-by: Duc Nguyen <[email protected]>
DucNgn
force-pushed
the
dn/stopWidgetsClose
branch
from
e768066 to
62fa8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #8730
deletedSuffixto(deleted).workbench.editor.closeOnFileDelete(falseby default) to control whether the editor should be closed if other processes deleted or renamed the file.How to test
Observe:
Note: Regardless of the setting, dirty editors should not be closed when other processes
deletedorrenamedthe file.closeOnFileDeleteis true => the editor is closed.closeOnFileDeleteis false => the editor is kept alive with the change in the title (readme.md (deleted))Review checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen [email protected]