Improve documentation for the configure of package.json #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@zhaomenghuan please be sure to add a proper sign-off to the commit so we can accept your changes (at the moment the eca check fails due to it).
vince-fugnitto
added
documentation
zhaomenghuan
force-pushed
the
doc/improve-documentation
branch
4 times, most recently
from
fedde48 to
b3f3af4
Compare
The following commit adds documentation to the `cli`, to document the electron target configuration including the possible options such as `disallowReloadKeybinding` and `windowOptions`. Signed-off-by: zhaomenghuan <[email protected]> Improve documentation for the configure of package.json Signed-off-by: zhaomenghuan <[email protected]>
vince-fugnitto
force-pushed
the
doc/improve-documentation
branch
from
b3f3af4 to
e53e683
Compare
vince-fugnitto
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Improve documentation for the configure of package.json
How to test
Documentation changes only
Review checklist
Reminder for reviewers
Signed-off-by: zhaomenghuan [email protected]