explorer: fixed 'doOpenNode' implementation #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
The following commit fixes an issue with the `explorer` where the workspace folder node is incorrectly opened (despite not being visible) causing an issue where the explorer is empty. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/nav-fix
branch
from
906e99a to
ff5abc8
Compare
vince-fugnitto
changed the title
RomanNikitenko
approved these changes
Oct 22, 2020
DucNgn
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #8658
The following pull-request addresses the bug present in the
explorer(navigator) when no selection is present, and the ENTER keybinding to open a node is triggered. Since the root node is not visible, the explorer ends up in a state where the tree is hidden producing a negative user-experience.In order to fix the issue, the
doOpenNodeimplementation for theFileNavigatorModelis updated to only attempt to open nodes which are not explicitly hidden since they cannot be opened.master:
pull-request:
How to test
theia)npm scripts)explorer(ex: using the collapse-all command or toolbar item)Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]