Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix deprecation warnings in tests #8642

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request includes the following updates:

  1. updates the tests to fix deprecation and other warnings
  2. updates the ext:build script to reduce verbosity
  3. updates the repo's build script to reduce verbosity.

The verbosity during the build was not useful as it never displayed any relevant information when building individual extensions and would ultimately pollute the log. The verbosity is now lowered, and only relevant information such as errors and warnings will now be displayed. This also helps navigating the log during CI.

How to test

  1. verify that the build successfully passes during CI
  2. verify that the tests successfully pass during CI
  3. verify that the overall deprecation warnings from tests has been fixed.

Review checklist

Reminder for reviewers

@vince-fugnitto vince-fugnitto added quality issues related to code and application quality test issues related to unit and api tests labels Oct 15, 2020
@vince-fugnitto vince-fugnitto self-assigned this Oct 15, 2020
vince-fugnitto and others added 3 commits October 16, 2020 08:35
The following commit updates the tests to fix any deprecations, and other linting
warnings.

Signed-off-by: vince-fugnitto <[email protected]>
Co-authored-by: marechal-p <[email protected]>
The following commit reduces the verbosity of the `build` command so the
build log is not polluted but still displays warnings and errors.

Signed-off-by: vince-fugnitto <[email protected]>
The following commit reduces the `verbosity` during a build of
the project, while still displaying warnings, and errors.

The verbose build does not display any relevant information, and
polutes the log, as well as during CI.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto merged commit 04cf597 into master Oct 20, 2020
@vince-fugnitto vince-fugnitto deleted the vf/deprecated-tests branch October 20, 2020 15:49
@github-actions github-actions bot added this to the 1.7.0 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality test issues related to unit and api tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants