Add documentation for Keybinding, KeybindingContribution and KeybindingRegistry #8637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasHelming
changed the title
vince-fugnitto
added
documentation
There was a problem hiding this comment.
@JonasHelming I had a few comments, namely about the use of {@link} and the naming.
I noticed we had multiple different types of representations of the word keybinding that I thought we should align throughout the documentation:
keybindingkey bindingKeyBinding
The single keybinding naming would be sufficient.
1 task
JonasHelming
force-pushed
the
keybinding
branch
from
61b9740
to
d4c91bf
Compare
There was a problem hiding this comment.
@JonasHelming please squash the commits and ensure that there is a proper sign-off (for the eclipse eca check) before we can proceed with an approval.
JonasHelming
force-pushed
the
keybinding
branch
from
d4c91bf
to
728a8f5
Compare
fixes eclipse-theia#8636 Contributed on behalf of STMicroelectronics Signed-off-by: Jonas Helming <[email protected]>
JonasHelming
force-pushed
the
keybinding
branch
from
728a8f5
to
1cda047
Compare
|
sure, done! |
vince-fugnitto
approved these changes
Oct 22, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8636
Contributed on behalf of STMicroelectronics
Signed-off-by: Jonas Helming [email protected]
What it does
Adds/refines documentation for Keybinding, KeybindingContribution, KeyBindingRegistry
How to test
Documentation only
Review checklist
Reminder for reviewers