Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SCM accept input commnad #8606

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fix SCM accept input commnad #8606

merged 1 commit into from
Oct 9, 2020

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur [email protected]

What it does

Pass native arguments of the SCM acceptInputCommand to plugin side, instead of passing an ScmRepository object to avoid Converting circular structure to JSON error.

How to test

  1. Remove "@theia/git": ... from examples/browser/package.json file.
  2. Download vscode-git-1.44.2 and copy it to the plugins folder.
  3. Compile and start Theia and open a workspace with some project cloned from GitHub and make some changes in it.
  4. Open the SCM panel and stage the changes.:
    screenshot-github com-2020 10 07-16_33_54
  5. Type a commit message and press CTRL + ENTER.

See: commit successfully added.

fixes eclipse-che/che#18067

Review checklist

Reminder for reviewers

@vinokurig vinokurig requested a review from akosyakov October 8, 2020 12:28
@vinokurig vinokurig added git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager vscode issues related to VSCode compatibility bug bugs found in the application labels Oct 8, 2020
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ctrl+Enter works now. Thanks!

Signed-off-by: Igor Vinokur <[email protected]>
@vinokurig vinokurig merged commit 5eb6efa into master Oct 9, 2020
@vinokurig vinokurig deleted the che-18067 branch October 9, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git commit hot key doesn't work
2 participants