markers: add additional problem-manager tests #8604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
quality
The following commit updates the `problem-manager` tests: - updates the existing unit tests. - adds additional tests: - adds tests to find uris. - adds tests to verify the problem stats. - adds additional `findMarker` tests for different filters. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/problems-tests
branch
from
c1b53f1 to
6222635
Compare
|
@marechal-p I updated the |
paul-marechal
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The following pull-request adds additional tests for the
problem-manageras well as refactorings:ProblemManager.cleanAllMarkersVerify that the method correctly cleans all available markers.
ProblemManager.findMarkersVerify that the method correctly returns markers for different filters.
ProblemManager.getUrisVerify that the method correctly returns the number of uris under different circumstances.
ProblemManager.getProblemStatVerify that the method correctly returns the total number problem stats (
errors,warnings,infos) under different circumstances.How to test
Verify the content, the CI should successfully pass (build and tests).
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto [email protected]