[scm] Add check to determine which scm-widget should be focused #8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Focus should be on node rather than `commitWidget` when there is no repository in the workspace. Signed-off-by: Duc Nguyen <[email protected]> Co-authored-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
quality
kittaakos
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
commitWidgetis visible (means there is a repository in the workspace), then focus is oncommitWidgetcommitWidgetwhen there is no repository in the workspace.How to test
scmReview checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen [email protected]
Co-authored-by: Vincent Fugnitto [email protected]