Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiate the returned FileSystem object for the frontend binding #8507

Conversation

slhultgren
Copy link
Contributor

@slhultgren slhultgren commented Sep 15, 2020

What it does

Fixes: #8497

How to test

With this patch this following code will now work properly:

@inject(FileSystem)
protected readonly fileSystem: FileSystem;

...

console.log("fileSystem.exists: " + this.fileSystem.exists);
console.log("file system root exists ? " + await this.fileSystem.exists("file:///"));

Will now work as expected instead of this.fileSystem.exists being undefined.

Review checklist

Reminder for reviewers

Signed-off-by: Samuel HULTGREN [email protected]

@slhultgren slhultgren force-pushed the issue_8497_instantiate_frontend_filesystem branch from 17297bc to ed540ee Compare September 18, 2020 05:45
@vince-fugnitto vince-fugnitto added the filesystem issues related to the filesystem label Sep 24, 2020
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution @slhultgren! 👍
The changes work well for me when attempting to use the deprecated FileSystem.

@vince-fugnitto vince-fugnitto merged commit 04c229b into eclipse-theia:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filesystem issues related to the filesystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@inject(FileSystem) will inject the type instead of the actual object
2 participants