-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply revealInExplorer vscode command #8496
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described 👍
@akosyakov @westbury is it OK for you to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig the reveal in explorer
works well except for the case that the explorer
does not exist in the layout. A similar scenario in vscode will open the explorer
and reveal.
@vinokurig Anton is offline this week |
Added open the file navigator if it closed. Could you please review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍
I verified that:
- the command reveals the proper resource in the explorer
- the command toggles the explorer first if it is does not exist before revealing
- performing a multi-selection reveal behaves similarly to vscode
@vinokurig would you like to merge for today's release? |
acd43eb
to
bbaca40
Compare
@vince-fugnitto Yes, I'll merge it when CI tests are passed. |
Signed-off-by: Igor Vinokur <[email protected]>
bbaca40
to
6ab2e73
Compare
What it does
Apply
revealInExplorer
built-in vscode command. It is used in the built-in vscode git extension: https://github.com/microsoft/vscode/blob/a5987ce853b0cd757f140f4618962a4e12522224/extensions/git/src/commands.ts#L2232.How to test
"@theia/git": "^1.5.0"
fromexamples/browser/package.json
file.plugins
folder.Reveal in Side Bar
See: the item is selected in the Navigator:
Review checklist
Reminder for reviewers