Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply revealInExplorer vscode command #8496

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Sep 11, 2020

What it does

Apply revealInExplorer built-in vscode command. It is used in the built-in vscode git extension: https://github.com/microsoft/vscode/blob/a5987ce853b0cd757f140f4618962a4e12522224/extensions/git/src/commands.ts#L2232.

How to test

  1. Remove "@theia/git": "^1.5.0" from examples/browser/package.json file.
  2. Download vscode-git-1.44.2 and copy it to the plugins folder.
  3. Compile and start theia with a project cloned from github.
  4. Make some changes in the project.
  5. Open the Source Control panel and right mouse click to a changed item => Reveal in Side Bar
    See: the item is selected in the Navigator:
    video-convert

Review checklist

Reminder for reviewers

@vinokurig vinokurig added git issues related to git vscode issues related to VSCode compatibility commands issues related to application commands labels Sep 11, 2020
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described 👍

@vinokurig
Copy link
Contributor Author

@akosyakov @westbury is it OK for you to merge?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig the reveal in explorer works well except for the case that the explorer does not exist in the layout. A similar scenario in vscode will open the explorer and reveal.

@azatsarynnyy
Copy link
Member

@vinokurig Anton is offline this week

@vinokurig
Copy link
Contributor Author

@vince-fugnitto

@vinokurig the reveal in explorer works well except for the case that the explorer does not exist in the layout. A similar scenario in vscode will open the explorer and reveal.

Added open the file navigator if it closed. Could you please review it again?

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍
I verified that:

  • the command reveals the proper resource in the explorer
  • the command toggles the explorer first if it is does not exist before revealing
  • performing a multi-selection reveal behaves similarly to vscode

@vince-fugnitto
Copy link
Member

@vinokurig would you like to merge for today's release?

@vinokurig vinokurig force-pushed the revealInExplorerCommand branch 2 times, most recently from acd43eb to bbaca40 Compare September 24, 2020 13:10
@vinokurig
Copy link
Contributor Author

@vince-fugnitto Yes, I'll merge it when CI tests are passed.

@vinokurig vinokurig force-pushed the revealInExplorerCommand branch from bbaca40 to 6ab2e73 Compare September 24, 2020 13:59
@vinokurig vinokurig merged commit c6f6e22 into master Sep 24, 2020
@vinokurig vinokurig deleted the revealInExplorerCommand branch September 24, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands issues related to application commands git issues related to git vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants