fix debug exception height computation

[akosyakov]

Signed-off-by: Anton Kosyakov [email protected]

What it does

• fix node debug exception breakpoint stripe issues #8225: fix debug exception height computation

How to test

• create a.js file with following content:

var a = 5;
console.log(a);
if (a>2) {
    throw new Error("Error");
}
console.log("End");

• use Launch with Node.js debug configuration to debug it
• enable exception breakpoint
• rerun the debug configuration again
• the exception breakpoint should not overflow editor content
• it should stay the same when you modify a file
• when you switch to another file the exception widget should not be visible
• but should appear when you come back

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[vince-fugnitto]

The changes work very well:

master:

pull-request:

[danidoedel]

The margin at the bottom is now bigger than the one at the top. Is that intended behavior? According to the screenshot in the ticket it seems to be equal for VS Code. Just wondering 😉

[akosyakov]

@danidoedel I've noticed it too. That's because zone (distance between lines) height is computed by Monaco, but content height is by browser. If it try to match it then with each edit content height grows by 2px which leads to overflow eventually. I guess it is the same issue in VS Code.

[DoroNahari]

I tried this change on gitpod now and it doesn't worked well for me:

[akosyakov]

@DoroNahari hm, I cannot reproduce it. Are sure that you are trying Theia from this PR, not Gitpod Theia? on the image below it is a tab without Gitpod logo:

@vince-fugnitto @amiramw Could you try to reproduce?

[vince-fugnitto]

@vince-fugnitto @amiramw Could you try to reproduce?

I verified again using Gitpod and it worked correctly:

[amiramw]

For me it tested successfully. Both these issues are solved now:

• Stripe covering the code.
• When moving to another opened tab the stripe stays.

(in #8344 the second issue was not solved)

There is some difference on behavior comparing to vs code but I think I'm fine with it:

when you resize the browser window to be smaller the stripe height stays the same and the bottom of the stack trace is disappearing. In vs code the stripe height is getting bigger on such resize.

[amiramw]

maybe currentFrame?.source?.uri?.toString() !== this.uri.toString()

[akosyakov]

@amiramw Could you try again? resizing should be handled as well now

[amiramw]

Resizing is responding well now. 👍

[akosyakov]

@amiramw Could you check please with @DoroNahari as well? If you can do it offline. It is important for me that we don't overlook something.

[DoroNahari]

LGTM