[electron]: Fixed the window reloading issue.

[kittaakos]

Refs:

• Renderer Node fs API stops working on page reload when allowRendererProcessReuse is true electron/electron#22119,
• [Discussion] Requiring Native Modules in the Renderer Process to be NAPI or Context Aware electron/electron#18397, and
• chore: add deprecation warning for the default of allowRendererProcessReuse electron/electron#21287
  Signed-off-by: Akos Kitta [email protected]

What it does

Fixes the browser window reload on Windows. @mcgordonite, could you please verify the behavior with and without this change on Windows?

How to test

Try to reset the workbench layout. It should reload the browser window.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

@vince-fugnitto @marechal-p could you check please? it sounds like an important regression after Electron 9 migration

[mcgordonite]

Hi @kittaakos, I should have time to verify this change tomorrow.

[kittaakos]

@mcgordonite, do you happen to have time to verify the Reset Workbench Layout command behavior on Windows. With the master version, the browser window never reloads after resetting the workbench layout with the electron example. With this change, it should work, hopefully 🤞 Thank you!

[mcgordonite]

@kittaakos just tested the behaviour on Windows:

• On master the workbench reset starts the page reload, then hangs on the loading spinner. This also happens when using the "reload window" command.
• On this PR, with allowRendererProcessReuse false, workbench reset works correctly.

[kittaakos]

just tested

Thank you for your help, @mcgordonite

[vince-fugnitto]

@kittaakos unfortunately I was unable to test since I don't have a Windows machine.
I did try the pull-request on Linux and did not notice any regressions.

[akosyakov]

Is it fine to approve on @mcgordonite behalf or someone else is going to try?

[kittaakos]

@tsmaeder, can you please help us with the review?

[paul-marechal]

@kittaakos just tested the behaviour on Windows:

• On master the workbench reset starts the page reload, then hangs on the loading spinner. This also happens when using the "reload window" command.
• On this PR, with allowRendererProcessReuse false, workbench reset works correctly.

Tried on Windows too and I can confirm that this fixes the issue. According to the doc the old value was false as well, so LGTM.