[monaco] non-blocking bulk edits

[akosyakov]

What it does

• fix [monaco] bulk editor service is not safe to use concurrently #8328: apply text edits without requiring an editor to be revealed or focused, otherwise it is not guarantee that edits from multiple bulk calls will be applied in the proper order. I've discovered an issue with the private VS Code extension doing modifications in the background, by the time when a window was revealed the document was total mess.
• This PR as well fixes bugs of:
  • marking a document as dirty with changes which lead to the same state, thinking replace the entire doc with the same content;
  • not respecting EOL changes.

How to test

Apply some cross file refactoring for Typescript or Java, like rename type referenced from other files. Other files still should be opened as dirty and changes should be applied.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[RomanNikitenko]

@akosyakov
I tested renaming for a typescript type with and without Auto Save.
The changes are applied for both cases.

Other files still should be opened as dirty

I can see that behavior if Auto Save is turned off.

I see some difference with VS Code behavior:

• VS Code does not open related files for applying changes if Auto Save is turned on:
• VS Code opens related files if Auto Save is turned off

Just a question - if it was expected to align the behavior with VS Code within current PR?

[akosyakov]

Just a question - if it was expected to align the behavior with VS Code within current PR?

To some extent yes, my main concern was to resolve blocking issues though. I will look how hard is to align auto save handling.

[akosyakov]

@RomanNikitenko I've pushed another commit to only save model if auto save is on.

[kittaakos]

@akosyakov, please remove the EditorOpenerOptions arg as it is unused. As a downstream consumer, I want to see a compiler error if the behavior has changed. Please add the breaking changes you made to the changelog. Thanks!

[akosyakov]

please remove the EditorOpenerOptions arg as it is unused As a downstream consumer, I want to see a compiler error if the behavior has changed.

sorry did not get it. EditorOpenerOptions is used in EditorManager. The behaviour is changed only for case with auto save on, in other cases it should work as before but non-blocking and respect EOL changes.

[kittaakos]

sorry did not get it.

I do not see the options arg used by the applyBulkEdit method.

[akosyakov]

@kittaakos good catch! removed and updated CHANGELOG

[RomanNikitenko]

Tested after update: mentioned use case was aligned with VS Code behavior

[vince-fugnitto]

The changes work well (tested using a cross-file rename symbol):

• autoSave = on:
  The edit completes successfully without the need to open the editors
• autoSave = off:
  The edit completes successfully, corresponding files are opened (marked as dirty) with the proper edit changes